Skip to content

Conversation

@kirkwaiblinger
Copy link
Member

PR Checklist

Overview

I've just put up an initial message; iteration and criticism is very much invited!

@typescript-eslint/triage-team

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Dec 10, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 8e1a518
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/6939840d669f4f000879ce21
😎 Deploy Preview https://deploy-preview-11836--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 97 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@kirkwaiblinger kirkwaiblinger requested a review from a team December 10, 2025 14:30
@kirkwaiblinger kirkwaiblinger marked this pull request as ready for review December 10, 2025 14:31
@nx-cloud
Copy link

nx-cloud bot commented Dec 10, 2025

View your CI Pipeline Execution ↗ for commit 8e1a518

Command Status Duration Result
nx run-many -t lint ✅ Succeeded 3m 20s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 10s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 5s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 2s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 3s View ↗
nx run integration-tests:test ✅ Succeeded 4s View ↗
nx run types:build ✅ Succeeded 2s View ↗
nx run generate-configs ✅ Succeeded 6s View ↗
Additional runs (29) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-12-10 14:36:28 UTC


While we cannot and will not attempt to ban contributions which make use of AI, we ask that you use AI responsibly:

- Always review AI-generated content closely
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me this is little vague does this mean the person who send the PR or reviewer. I guess kinda both.

Could this section be written even more cleaner, while stressing that before opening a PR make sure you have reviewed the code yourself, and that you can understand what it does and why. I fear that using language like “to champion” is not easiest to understand for people who are most likely to offend it.

Generally I think this is good addition and doesn’t sound too negative but keeps the welcoming spirit that this project has :)

Copy link
Member

@bradzacher bradzacher Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also suggest adding this:

Suggested change
- Always review AI-generated content closely
- Always review AI-generated content closely **_before submitting a PR._**

To emphasise that we don't want people to vibe a change, ping us with a PR creation and then review it later.

- Only use AI for contributions that you would understand well enough to champion and respond to feedback on without making use of AI
- Do not ignore our issue and PR templates

Don't let this dissuade you from contributing to typescript-eslint! We are generally more than happy to assist new contributors and help them improve at our repo. We just are not interested in babysitting anyone's LLM instances.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of saying babysitting, could it this address the problem I have seen, where the person opening PR is acting agent between reviewer and the LLM? “We are capable of running LLMs ourselves and we are not interested in prompting them via PR reviews”?

Copy link
Member

@bradzacher bradzacher Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call out yeah.

If the persons entire role in the process is agentic middleman then we ask that they remove themselves from the process entirely and just not submit the PR.

We can talk to the agent without them as a go-between.


- Always review AI-generated content closely
- Only use AI for contributions that you would understand well enough to champion and respond to feedback on without making use of AI
- Do not ignore our issue and PR templates
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible addition (or some variation of)

Avoid AI generated PR descriptions as they are usually just a verbatim summary of the code.

We require that you summarise your PR changes yourself in your own words. If you cannot summarise your change then you do not understand your change and should not be raising the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs: Establish and document expectations around use of AI in contributions

3 participants