fix(eslint-plugin): [prefer-optional-chain] handle MemberExpression in final chain position #11835
+458
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the PR, @mdm317! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit 2838efc
☁️ Nx Cloud last updated this comment at |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11835 +/- ##
==========================================
+ Coverage 90.53% 90.55% +0.01%
==========================================
Files 523 523
Lines 53096 53140 +44
Branches 8838 8846 +8
==========================================
+ Hits 48073 48122 +49
+ Misses 5010 5005 -5
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
[x] That issue was marked as accepting prs
Problem
BinaryExpression nodes where both left and right are MemberExpression are not checked,
a === null || a.b !== foo.three; // bug: should be flagged/fixable, is notand CallExpression nodes whose callee is a MemberExpression are not treated as MemberExpression.
a === null || a.b !== a.c();Fix
MemberBasedExpression, which covers botha.banda.b().unknownto theyodaenumLogic for
yoda: unknownBinaryExpressionnodes where both sides areMemberBasedExpression, setyodatounknown.a.b != a.c,a.b != c.dyodaisunknownand both sides are subsets of theprevious chain, skip the transformation inanalyzeChain.