Skip to content

chore: check variable declaration syntax error against tsNode #11778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
fisker wants to merge 12 commits into
base: main
Choose a base branch
from
Open

chore: check variable declaration syntax error against tsNode #11778

fisker wants to merge 12 commits into from
+97 −80

Conversation

@fisker
Copy link
Contributor

@fisker fisker commented Nov 23, 2025 •
edited
Loading

PR Checklist

Overview

Same as #11777

The syntax check should always check against TS node instead of ESTree node before convert, prepare for #11695

No logic changes, just refactor.

Note: this contains changes from #11777, but fixed both VariableDeclaration, VariableDeclarationList, and VariableStatement.

If smaller changes are preferred, I'll rebase after #11777 gets merged.

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Nov 23, 2025

Thanks for the PR, @fisker!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Nov 23, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit a7fdcfc
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/692db20651be9200083df7c4
😎 Deploy Preview https://deploy-preview-11778--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (🔴 down 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link

nx-cloud bot commented Nov 23, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit a7fdcfc

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 11s View ↗
nx run-many -t lint ✅ Succeeded 3m 15s View ↗
nx run-many -t typecheck ✅ Succeeded 1m 55s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 21s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 10s View ↗
nx run integration-tests:test ✅ Succeeded 5s View ↗
nx run types:build ✅ Succeeded 2s View ↗
nx run generate-configs ✅ Succeeded 6s View ↗
Additional runs (29) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-12-01 15:32:27 UTC

@codecov
Copy link

codecov bot commented Nov 23, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 40.50633% with 47 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.55%. Comparing base (5ac66a6) to head (a7fdcfc).

Files with missing lines Patch % Lines
packages/typescript-estree/src/convert.ts 40.50% 47 Missing ⚠️

❌ Your patch check has failed because the patch coverage (40.50%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11778      +/-   ##
==========================================
+ Coverage   90.53%   90.55%   +0.01%     
==========================================
  Files         523      523              
  Lines       53097    53105       +8     
  Branches     8838     8839       +1     
==========================================
+ Hits        48074    48088      +14     
+ Misses       5010     5004       -6     
  Partials       13       13
Flag Coverage Δ
unittest 90.55% <40.50%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/typescript-estree/src/convert.ts 31.29% <40.50%> (+0.39%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fisker fisker marked this pull request as ready for review November 23, 2025 08:06
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Nov 24, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me, thanks!

+1 to merging in #11777 first.

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Nov 24, 2025
@fisker fisker mentioned this pull request Nov 27, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fisker @JoshuaKGoldberg