fix(typescript-estree): if the template literal is tagged and the text has an invalid escape, `cooked` will be `null` #11355

nayounsang · 2025-06-28T08:59:36Z

PR Checklist

Addresses an existing open issue: fixes Bug: Wrong cooked value of TemplateElement in TaggedTemplateExpression #11353
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

ref: https://github.com/estree/estree/blob/2bc9ea235184b6164e31b1088575447657e686c6/es2018.md?plain=1#L34

change type of cooked in the ast-spec
- also update snapshot
eval string to check for incorrect escaping
add test case
affected these rule
- plugin-test-formatting : ignore when cooked is null
- no-unsafe-assignment: ignore when cooked is null
- no-duplicate-enum-values: There can be no null case. If value is tagged, it causes ts error and the existing logic only assumes that it is not tagged.

…, cooked will be null

typescript-eslint · 2025-06-28T08:59:39Z

Thanks for the PR, @nayounsang!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2025-06-28T08:59:40Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`50871ad`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/692ebeaf76d9910008d33dd7
😎 Deploy Preview	https://deploy-preview-11355--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (🟢 up 4 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

nx-cloud · 2025-06-28T09:00:58Z

View your CI Pipeline Execution ↗ for commit f43e69b

Command	Status	Duration	Result
`nx run-many -t lint`	✅ Succeeded	3m 18s	View ↗
`nx test eslint-plugin --coverage=false`	✅ Succeeded	5m 6s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	21s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	2m 16s	View ↗
`nx run types:build`	✅ Succeeded	6s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	11s	View ↗
`nx run generate-configs`	✅ Succeeded	6s	View ↗
`nx run integration-tests:test`	✅ Succeeded	4s	View ↗
`Additional runs (27)`	✅ Succeeded	...	View ↗

☁️ Nx Cloud last updated this comment at 2025-09-15 13:21:30 UTC

nayounsang · 2025-06-28T13:41:49Z

It's strange. In my local, I cleared the cache and the changed types were built in the types package. Isn't the CI environment a new virtual machine that runs anyway?

typescript-estree has a dependency on types. TemplateElement comes from types
TemplateElement in types is auto-generated by ast-spec.
In nx cloud, types is hitting cache in CI.
So, changes are not updated and an error occurs.
Do I need to do something separate?

…, cooked will be null

nayounsang · 2025-07-20T10:46:18Z

hi @JamesHenry
Thank you for your efforts on this difficult problem.

Can I continue working on this PR?
Is it okay if I merge with the main branch and resolve conflicts freely?
If CI-related work is not completed, can I help?

JamesHenry · 2025-07-21T08:50:40Z

@nayounsang Yes, sorry I forgot about this one, I obviously kept iterating on your other one to discover that one wasn't a caching issue. This one might be related to your other one or it might be totally separate.

Please revert my changes when you fix up the conflicts and let's get back to a clean slate. If it's still failing unexpectedly after that I can take another look

…slint into tag-cook

JamesHenry · 2025-07-24T08:29:10Z

@nayounsang I see you're doing a lot of pushes that result in failed tasks. Are you running these things locally before pushing? Ideally you would iterate locally to get the high priority tasks passing and then push up to CI to verify in a neutral environment

nayounsang · 2025-09-07T14:41:19Z

CI is failed again.. I guess more work is needed

packages/types/package.json

packages/typescript-estree/tests/lib/convert.test.ts

packages/eslint-plugin-internal/tests/rules/plugin-test-formatting.test.ts

…slint into tag-cook

kirkwaiblinger · 2025-12-08T15:51:41Z

packages/eslint-plugin/src/rules/no-unsafe-assignment.ts

        ) {
-          key = receiverProperty.key.quasis[0].value.cooked;
+          const cooked = receiverProperty.key.quasis[0].value.cooked;
+          if (cooked == null) {


This is an impossible condition (and the test provided doesn't reach it).

This branch refers to keys whose node type is a TemplateLiteral... Which necessarily means they are untagged. If it were tagged it would have the TaggedTemplateExpression.

Suggestion:
Use nullThrows() instead

kirkwaiblinger · 2025-12-08T15:54:33Z

packages/eslint-plugin/src/rules/no-duplicate-enum-values.ts

-            value = member.initializer.quasis[0].value.cooked;
+            // cooked can only be null inside a TaggedTemplateExpression, which is not possible.
+            // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+            value = member.initializer.quasis[0].value.cooked!;


Suggestion: Use nullThrows() here instead

kirkwaiblinger · 2025-12-08T16:02:41Z

packages/typescript-estree/src/convert.ts

-              node,
-            ),
-        });
+        const result = this.createNode<TSESTree.TaggedTemplateExpression>(


nayounsang added 3 commits June 28, 2025 16:22

test: add test case

cbe8cc9

feat: make flag whether node is inside tag

a1902bb

fix: if template literal is tagged and the text has an invalid escape…

4938a14

…, cooked will be null

nayounsang marked this pull request as draft June 28, 2025 08:59

nayounsang changed the title ~~fix(typescript-estree): If the template literal is tagged and the text has an invalid escape, cooked will be null~~ fix(typescript-estree): if the template literal is tagged and the text has an invalid escape, cooked will be null Jun 28, 2025

fix: type error

77960bf

nayounsang added 6 commits June 28, 2025 23:17

chore: add snapshot

c11a244

test: add test case

cd7550f

feat: make flag whether node is inside tag

156b384

fix: if template literal is tagged and the text has an invalid escape…

6103105

…, cooked will be null

fix: type error

cbeb8d7

chore: add snapshot

954e84e

JamesHenry force-pushed the tag-cook branch from c6eaaf7 to 954e84e Compare July 1, 2025 13:13

JamesHenry added 2 commits July 1, 2025 17:43

Merge branch 'main' into tag-cook

b5bc96d

chore: try with SKIP_AST_SPEC_REBUILD false

8fdb4db

nayounsang added 8 commits July 23, 2025 15:02

Merge branch 'main' into tag-cook

2dc7c7b

fix: fallback when cooked is null

2e5857a

Merge branch 'tag-cook' of https://github.com/nayounsang/typescript-e…

8279f15

…slint into tag-cook

chore: temp commit to see ci result

49dcf05

fix: try to change input

84ec93c

fix: mis config input

814604f

chore: off ast spec env

888e312

fix: lint err

4c1891c

nayounsang added 2 commits September 6, 2025 14:48

Merge branch 'main' into tag-cook

bcd84fa

chore: revert result of nx sync

58ab6ae

nayounsang added 3 commits September 14, 2025 18:00

Merge branch 'main' into tag-cook

2f95549

chore: remove unraw

6fb4c78

chore: set genrated type as nx input to type build

10cdcd2

nayounsang commented Sep 14, 2025

View reviewed changes

packages/types/package.json Show resolved Hide resolved

feat: process rules when cooked is null

e31cdbc

nayounsang requested review from JamesHenry and JoshuaKGoldberg September 14, 2025 16:40

github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Sep 14, 2025

nayounsang requested a review from fisker September 14, 2025 16:42

fisker reviewed Sep 14, 2025

View reviewed changes

packages/typescript-estree/tests/lib/convert.test.ts Show resolved Hide resolved

fix: case for head,middle and tail

f43e69b

JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Sep 15, 2025

nayounsang added 3 commits November 19, 2025 17:53

chore: install @babel/helper-string-parser

800deba

chore: remove @babel/helper-string-parse and install unraw

42368ec

feat: use unraw when validate

d86ddbc

nayounsang requested a review from fisker November 19, 2025 11:42

github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Nov 19, 2025

bradzacher reviewed Nov 23, 2025

View reviewed changes

packages/eslint-plugin-internal/tests/rules/plugin-test-formatting.test.ts Outdated Show resolved Hide resolved

Apply suggestion from @bradzacher

66b757d

bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Nov 23, 2025

fisker mentioned this pull request Nov 23, 2025

Remove requirement of TemplateElement.value.cooked in tagged template literal estree/estree#333

Closed

nayounsang added 3 commits December 2, 2025 19:24

chore: remove unraw

1d73e5b

feat: simple valid logic for invalid esacpe

2d05e47

Merge branch 'tag-cook' of https://github.com/nayounsang/typescript-e…

50871ad

…slint into tag-cook

nayounsang requested a review from bradzacher December 2, 2025 10:29

github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Dec 2, 2025

kirkwaiblinger reviewed Dec 8, 2025

View reviewed changes

Uh oh!

fix(typescript-estree): if the template literal is tagged and the text has an invalid escape, cooked will be null #11355

Are you sure you want to change the base?

fix(typescript-estree): if the template literal is tagged and the text has an invalid escape, cooked will be null #11355

Conversation

nayounsang commented Jun 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslint bot commented Jun 28, 2025

Uh oh!

netlify bot commented Jun 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for typescript-eslint ready!

Uh oh!

nx-cloud bot commented Jun 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nayounsang commented Jun 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nayounsang commented Jul 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JamesHenry commented Jul 21, 2025

Uh oh!

JamesHenry commented Jul 24, 2025

Uh oh!

nayounsang commented Sep 7, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kirkwaiblinger Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

kirkwaiblinger Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

kirkwaiblinger Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

fix(typescript-estree): if the template literal is tagged and the text has an invalid escape, `cooked` will be `null` #11355

fix(typescript-estree): if the template literal is tagged and the text has an invalid escape, `cooked` will be `null` #11355

nayounsang commented Jun 28, 2025 •

edited

Loading

netlify bot commented Jun 28, 2025 •

edited

Loading

nx-cloud bot commented Jun 28, 2025 •

edited

Loading

nayounsang commented Jun 28, 2025 •

edited

Loading

nayounsang commented Jul 20, 2025 •

edited

Loading