Fix NPE in Scala 3 derivation for Write #1890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jatcwang
reviewed
Jul 7, 2023
|
|
||
| And find the missing instance and construct it as needed. Refer to Chapter 12 | ||
| of the book of doobie for more information. | ||
| """) |
There was a problem hiding this comment.
This is amazing. Thank you! 💯
|
Oopsie my bad I should've fixed Write too. Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1816 fixed NPE for Read instances, but bug persisted for Write instances.
@jatcwang mentioned that recursive definitions for Read do not exist, if that's also the case for Write we can make the same change as in #1816 but for Write.
5d52836 commit introduces test that succeeds for Read, but fails for Write. Next commit introduces the mentioned change that makes the Write test also pass.