Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Config case class #1541

Merged
merged 7 commits into from
Sep 1, 2021
Merged

Add Config case class #1541

merged 7 commits into from
Sep 1, 2021

Conversation

sideeffffect
Copy link
Contributor

@sideeffffect sideeffffect commented Aug 31, 2021 •
edited
Loading

Revival of #1126

Adds

  • a configuration case class that is suitable for PureConfig
  • helper method Config.makeHikariConfig for creating a com.zaxxer.hikari.HikariConfig
  • helper method HikariTransactor.fromConfig for creating a doobie.hikari.HikariTransactor

@sideeffffect sideeffffect mentioned this pull request Aug 31, 2021
Closed
@sideeffffect
Merge branch 'main' into config
c017696 
# Conflicts:
#	modules/hikari/src/main/scala/doobie/hikari/HikariTransactor.scala
@jatcwang
Copy link
Collaborator

@sideeffffect main is now CE3 so if you do need this in CE2 then you can target series/0.13.x, or you can update this PR to CE3 :)

@sideeffffect
Copy link
Contributor Author

The PR is based on main already. I just needed to fix the headers.

@sideeffffect
Copy link
Contributor Author

Oh, actually you're right 🤦 I've made the necessary Cats Effect 3 changes.

@jatcwang jatcwang self-assigned this Sep 1, 2021
@jatcwang jatcwang merged commit 68580b2 into typelevel:main Sep 1, 2021
@sideeffffect sideeffffect deleted the config branch September 1, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jatcwang jatcwang jatcwang left review comments

Assignees

@jatcwang jatcwang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sideeffffect @jatcwang