Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Surface "unlabeled" in a way that can be referenced #1923

Closed
henricook opened this issue Sep 18, 2023 · 1 comment · Fixed by #1946
Closed

Minor: Surface "unlabeled" in a way that can be referenced #1923

henricook opened this issue Sep 18, 2023 · 1 comment · Fixed by #1946
Milestone

Comments

@henricook
Copy link

henricook commented Sep 18, 2023

I'm using a Doobie 1.x loghandler to expose execution times for my queries via a prometheus metrics endpoint from my application.

I only log queries that have a label (otherwise I wouldn't know what to call them), currently to check for a label in the logHandler I have to do:

if (label =!= "unlabeled") {

I'd be nice if I could get the "unlabeled" value from Doobie directly to defend against future changes and save the 'magic string'

It'd be better if label was an Option, but I appreciate that would probably be a significant breaking change!

@jatcwang jatcwang added this to the 1.0-RC5 milestone Sep 18, 2023
jatcwang added a commit that referenced this issue Nov 8, 2023
also remove unused method void

fixed #1923
jatcwang added a commit that referenced this issue Nov 8, 2023
also remove unused method void

fixed #1923
@henricook
Copy link
Author

Thanks @jatcwang @felix-hedenstrom !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants