Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix button visibility issue on dark theme #38115

Merged
merged 4 commits into from
Mar 2, 2023
Merged

Fix button visibility issue on dark theme #38115

merged 4 commits into from
Mar 2, 2023

Conversation

lavsemen
Copy link
Contributor

@lavsemen lavsemen commented Feb 25, 2023 •
edited by julien-deramond
Loading

Description

Fix button color change issue on switching to dark theme: Resolved an issue where the button color was not changing properly on switching to the dark theme.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Related issues

Closes #38113

@lavsemen lavsemen marked this pull request as ready for review February 25, 2023 11:11
@lavsemen lavsemen requested a review from a team as a code owner February 25, 2023 11:11
louismaximepiton
louismaximepiton reviewed Feb 27, 2023
View reviewed changes
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, nice catch!

Just a small enhancement and I think we're good to go. Thanks a lot for your PR 😄

scss/_buttons.scss Outdated Show resolved Hide resolved
@lavsemen
Copy link
Contributor Author

lavsemen commented Mar 2, 2023

@louismaximepiton Moved color to sass variable!

mdo
mdo approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two quick changes I'll make and then good to go, thanks!

scss/_variables.scss Outdated Show resolved Hide resolved
scss/_buttons.scss Outdated Show resolved Hide resolved
@mdo mdo merged commit 9a1f4ed into twbs:main Mar 2, 2023
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louismaximepiton louismaximepiton louismaximepiton left review comments

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
color mode css v5
Projects
No open projects
v5.3.0-alpha2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dark theme: Base button text is not visible
5 participants
@lavsemen @mdo @louismaximepiton @julien-deramond @KRISTOX575