Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shadow of .btn-link #38086

Merged
merged 2 commits into from
Feb 24, 2023
Merged

Fix shadow of .btn-link #38086

merged 2 commits into from
Feb 24, 2023

Conversation

Sir-Genius
Copy link
Contributor

The .btn-link shadow should use the value of $link-color because the colors specified in the variables $primary and $link-color may be different.

@Sir-Genius Sir-Genius requested a review from a team as a code owner February 20, 2023 11:29
romaricpascal
romaricpascal approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@romaricpascal romaricpascal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot thanks! The change looks fine to me 😊

@romaricpascal romaricpascal merged commit c634528 into twbs:main Feb 24, 2023
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romaricpascal romaricpascal romaricpascal approved these changes

Assignees
No one assigned
Labels
css v5
Projects
No open projects
v5.3.0-alpha2
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sir-Genius @romaricpascal @julien-deramond