Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List group: Better use of CSS var #37888

Merged

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Jan 16, 2023

Description

Use the good variables.
Remove some duplicate selectors inside the loop.
Tweak a bit the color used by each variable.

Rollback the :active state for the .list-group-item-action. Not sure about this one but I felt weird using this. I wasn't sure it was done on purpose, so I tried something. Let me know if you want me to change the color as it is right now in Bootstrap.

Motivation & Context

Have a consistent .active state.
Have some used code.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

NA

@mdo mdo merged commit b3febfb into twbs:main Jan 16, 2023
@mdo
Copy link
Member

mdo commented Jan 16, 2023

Active state wasn't intentional, thanks for the clean up here!

@louismaximepiton louismaximepiton deleted the main-lmp-list-group-small-refactoring branch January 17, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants