Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: update progress markup in Color modes page #37863

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Docs: update progress markup in Color modes page #37863

merged 1 commit into from
Jan 13, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Jan 12, 2023 •
edited
Loading

Description

Due to PRs happening at the same time, #36831 was merged after the big color modes one and we forgot to update the markup of the progress component in the "Color modes" page.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (NA) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

@julien-deramond julien-deramond marked this pull request as ready for review January 12, 2023 07:34
@mdo mdo merged commit 4536f60 into main Jan 13, 2023
@mdo mdo deleted the main-jd-update-progress-markup-in-color-modes-doc branch January 13, 2023 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
color mode docs v5
Projects
No open projects
v5.3.0-alpha2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julien-deramond @mdo