Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: fix typo for Sass vars references in Customize > Color modes > Building with Sass #37676

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Docs: fix typo for Sass vars references in Customize > Color modes > Building with Sass #37676

merged 1 commit into from
Dec 20, 2022

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Dec 20, 2022 •
edited
Loading

Related issues

Closes #37674

Description

This PR suggests to replace @var to $var for Sass variables mentioned in Customize > Color modes > Building with Sass.

!default is removed from the example as well since it is not needed.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • All new and existing tests passed

Live previews

@julien-deramond julien-deramond requested a review from mdo December 20, 2022 07:07
@julien-deramond julien-deramond marked this pull request as ready for review December 20, 2022 17:37
mdo
mdo approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh, thanks!

@mdo mdo merged commit 57228a6 into main Dec 20, 2022
@mdo mdo deleted the main-jd-fix-css-var-references-for-color-modes branch December 20, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
color mode docs
Projects
No open projects
v5.3.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The updated color-modes.md file to go with Dark Mode using ampersands for variables.
2 participants
@julien-deramond @mdo