Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent extraneous whitespace around date time inputs in Webkit #37350

Merged
merged 2 commits into from
Oct 30, 2022
Merged

Prevent extraneous whitespace around date time inputs in Webkit #37350

merged 2 commits into from
Oct 30, 2022

Conversation

stephenreay
Copy link
Contributor

@stephenreay stephenreay commented Oct 21, 2022 •
edited by mdo
Loading

Fixes #34433, closes #37313.

Description

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

#34433

@stephenreay stephenreay requested a review from a team as a code owner October 21, 2022 10:08
@mdo
Copy link
Member

mdo commented Oct 30, 2022

LGTM! Thoughts @julien-deramond?

julien-deramond
julien-deramond reviewed Oct 30, 2022
View reviewed changes
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well! Tried it on the latest versions of FF, Chrome, Safari and Edge + all Safari version until 13 (there was an issue with the rendering of CodePen with the 12 but I suppose it'll work as well).

@stephenreay In order to merge this PR could you please just update the corresponding value of FAIL ./dist/css/bootstrap.css: 29.5KB > 29.5KB (gzip) in .bundlewatch.config.json to set it to "maxSize": "27.75 kB".

@stephenreay
Copy link
Contributor Author

LGTM as well! Tried it on the latest versions of FF, Chrome, Safari and Edge + all Safari version until 13 (there was an issue with the rendering of CodePen with the 12 but I suppose it'll work as well).

@stephenreay In order to merge this PR could you please just update the corresponding value of FAIL ./dist/css/bootstrap.css: 29.5KB > 29.5KB (gzip) in .bundlewatch.config.json to set it to "maxSize": "27.75 kB".

Assuming you meant 29.75, done.

@julien-deramond julien-deramond self-requested a review October 30, 2022 12:07
@mdo mdo merged commit 4b54d22 into twbs:main Oct 30, 2022
@Turbo87
Copy link

Turbo87 commented Jun 16, 2023

should this be added to the Reboot file similar to how it was done in #30269?

@stephenreay stephenreay deleted the Fix-Safari-DateInput-Height branch June 16, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

Assignees
No one assigned
Labels
css v5
Projects
No open projects
v5.3.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix .form-control padding for date/time inputs Date Input has incorrect sizing in Safari
4 participants
@stephenreay @mdo @Turbo87 @julien-deramond