Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure Tab keyboard functionality after #37146 #37200

Merged
merged 5 commits into from
Oct 2, 2022
Merged

Ensure Tab keyboard functionality after #37146 #37200

merged 5 commits into from
Oct 2, 2022

Conversation

GeoSot
Copy link
Member

@GeoSot GeoSot commented Sep 24, 2022 •
edited
Loading

Description

After
1510c25.
https://twbs-bootstrap.netlify.app/docs/5.2/components/navs-tabs/#javascript-behavior,

@julien-deramond pointed out:

The user for navigating between the tabs has to do the following:

  • Press "Tab" -> "Home" is focused
  • Press "Right" -> "Profile" is selected (not really focused with the blue outline)
  • Press "Tab" -> "Profile" is focused
  • Press "Right" -> "Contact" is selected (not really focused with the blue outline)
  • Press "Tab" -> "Contact" is focused

/cc @patrickhlauke

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

@julien-deramond
Copy link
Member

julien-deramond commented Sep 24, 2022 •
edited
Loading

I haven't followed the topic around 1510c25 but I can confirm that this PR fixes the behaviour mentioned in the description and is back to normal as it was in the v5.2.

@patrickhlauke
Copy link
Member

confirming that, based on the live preview, this works as it should. assuming that this does not reintroduce the problem noted in #37107, and that the JS tests all still make sense, this looks good to me

@GeoSot GeoSot marked this pull request as ready for review September 27, 2022 00:10
@GeoSot GeoSot requested a review from a team as a code owner September 27, 2022 00:10
@GeoSot GeoSot force-pushed the gs/test-tabs-keyboard-functionality branch from 5506c3b to a6284c4 Compare September 27, 2022 22:58
julien-deramond
julien-deramond approved these changes Oct 2, 2022
View reviewed changes
Copy link
Member

@julien-deramond julien-deramond left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The keyboard behavior is fixed 🚀
@GeoSot I've added some focus spies in 2 other unit tests in df6485b (with the disabled states) just to add some extra-security. If you think it is unnecessary you can remove this commit :)

@XhmikosR XhmikosR merged commit d49d8ce into main Oct 2, 2022
@XhmikosR XhmikosR deleted the gs/test-tabs-keyboard-functionality branch October 2, 2022 10:05
@XhmikosR XhmikosR changed the title Ensure Tab keyboard functionality after #37146 merge Ensure Tab keyboard functionality after #37146 Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

Assignees
No one assigned
Labels
accessibility js squash v5
Projects
No open projects
v5.2.2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GeoSot @julien-deramond @patrickhlauke @XhmikosR