Dropdown: fix case with invalid markup #37190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoSot
force-pushed
the
gs/support-dropdown-backward-compatibility
branch
from
7a21478 to
eb609fe
Compare
julien-deramond
approved these changes
Sep 23, 2022
Member
julien-deramond
left a comment
julien-deramond
left a comment
There was a problem hiding this comment.
LGTM!
Before merging @XhmikosR would you be able to check if your issue is well-fixed in your project? I'm still unsure if what I reproduced with my manual tests was exactly your use case :)
Member
|
Thanks, I'll try to have a look at this in the next days! |
Member
|
Fix confirmed, thanks! |
XhmikosR
changed the title
XhmikosR
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backward compatibility. (Should be removed in v6)
closes #37111