Add workarounds for postcss values parser error #37079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
postcss-values-parser returns a syntax error when a negative value is provided in a `calc` function after a CSS variable. This is not an issue with Bootstrap itself, but a workaround to allow projects using postcss-values-parser to keep upgrading and compiling bootstrap Ref: shellscape/postcss-values-parser#138, twbs#35033 Fix: twbs#36851
julien-deramond
approved these changes
Sep 3, 2022
There was a problem hiding this comment.
Reviewed it this way:
- Put in place the reproductible environment given by @tagliala in the issue that fails
- Checkout this branch
- For each file,
cp ../bootstrap/scss/_file.scss node_modules/bootstrap/scss/_file.scss - Re-run
NODE_ENV=production bin/webpack - Result: compilation OK
IMO this PR can be merged as is. It would be better to have something in our CI to check this issue in the future but apart from a bad regex, I'm not thinking of anything else atm.
Thoughts @mdo?
mdo
approved these changes
Sep 4, 2022
10 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
postcss-values-parser returns a syntax error when a negative value is
provided in a
calcfunction after a CSS variable.This is not an issue with Bootstrap itself, but a workaround to allow
projects using postcss-values-parser to keep upgrading and compiling
bootstrap
Ref: shellscape/postcss-values-parser#138, #35033
Fix: #36851