Docs: Minor fixes in tables. #37047
Merged
Docs: Minor fixes in tables. #37047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-deramond
approved these changes
Aug 29, 2022
This comment was marked as duplicate.
This comment was marked as duplicate.
I think just to indicate that list groups can be used with the Tab plugin. I think in v6, maybe v5.x, we could split the Navs & Tabs page into separate pages. Tabs is just about JS functionality and works with any of our navs and list groups as far as I know. I think there was a PR to add support for arbitrary elements but I can't recall. @GeoSot might remember.
They definitely should be! Maybe open an issue to track, or tackle in a PR if you like :). |
|
This PR also has some conflicts—can you update and we can merge? |
mdo
approved these changes
Sep 1, 2022
louismaximepiton
force-pushed
the
main-lmp-docs-tables-fixes
branch
from
61caa0e to
82ca554
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few fixes in tables.
This leads me to other questions:
Tabjavascript documentation insideList-Group? Seems like it was just a copy-paste.Tabjavascript methods aren't in a<table>?