Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify social images and add ability to set per-page images #36804

Merged
merged 4 commits into from
Jul 26, 2022
Merged

Simplify social images and add ability to set per-page images #36804

merged 4 commits into from
Jul 26, 2022

Conversation

mdo
Copy link
Member

@mdo mdo commented Jul 21, 2022

Addressing a few things after v5.2.0 went stable:

  • Removes the homepage summary layout in favor of the larger image card (makes it more consistent with other pages)
  • Reuses new thumbnails for Webpack, Parcel, and Vite guides to add their new social images
  • Updates default social card to be larger for more retina friendly rendering and with new design

Possibly more custom cards to come, but might push that to separate PRs. Ideas welcome on this :).

@mdo mdo force-pushed the custom-social-images branch from 717db5b to ff470ce Compare July 21, 2022 17:07
julien-deramond
julien-deramond approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@julien-deramond julien-deramond left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way better when the pages are shared in social networks! Good catch!
I find bootstrap-social.png a bit heavy/large but I suppose it is for retina friendly rendering.

Tested the rendering manually and with:

site/layouts/partials/social.html Outdated Show resolved Hide resolved
@mdo mdo force-pushed the custom-social-images branch from ff470ce to e75dc7b Compare July 25, 2022 22:19
@mdo
Copy link
Member Author

mdo commented Jul 25, 2022

@julien-deramond Implemented your suggested changes and cleaned up a couple things. Thanks!

@julien-deramond julien-deramond self-requested a review July 26, 2022 05:49
julien-deramond
julien-deramond approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

mdo added 4 commits July 26, 2022 10:03
@mdo
Simplify social images and add ability to set per-page images
1d33bea 
- Removes the homepage summary layout in favor of the larger image card (makes it more consistent with other pages)
- Reuses new thumbnails for Webpack, Parcel, and Vite guides to add their new social images
@mdo
Update default social card
2477ca2
@mdo
Change description to subtitle, add longer description to match homepage
50fefce
@mdo
Remove social_image_path, use inline conditions for social images
f7b9fbf
@mdo mdo force-pushed the custom-social-images branch from e75dc7b to f7b9fbf Compare July 26, 2022 16:05
@mdo mdo merged commit 501faa2 into main Jul 26, 2022
@mdo mdo deleted the custom-social-images branch July 26, 2022 16:25
@XhmikosR XhmikosR mentioned this pull request Dec 25, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

Assignees
No one assigned
Labels
docs v5
Projects
No open projects
v5.2.1
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdo @julien-deramond