Remove "extra" section from composer.json #29420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This section is meaningless and doesn't serve any purpose.
Closed
|
In the past, i.e. when v4 was being developed, development happened on Do you think this could break things if we remove it? |
|
No, unless someone would require another package that depends on the version being developed, e.g. Basically this section only serves as a mapping and is only useful if other packages depend on specific versions being developed. I would say it's absolutely safe to remove it. |
mdo
approved these changes
Sep 27, 2019
lucanos
pushed a commit
to lucanos/bootstrap
that referenced
this pull request
Oct 27, 2019
This section is meaningless and doesn't serve any purpose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This section is meaningless and doesn't serve any purpose.
To give some more context: The branch alias is good for mapping
dev-master(which is the latest dev version of a project) to a specific development branch. But if yourmasterbranch is always the latest dev version (as it is the case with Bootstrap), no mapping is needed.Only problem could be, if another package is requiring a specific version and that conflicts with
dev-master(on themaster) branch if there's no alias set. But I would say this is VERY unlikely with a project like Bootstrap.See also https://getcomposer.org/doc/articles/aliases.md#branch-alias .