Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pipelines and update output for composite mod #5

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

vkumbha
Copy link
Contributor

@vkumbha vkumbha commented Nov 17, 2023

Checklist

  • Issue(s) linked

Copy link
Contributor

@cbruno10 cbruno10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vkumbha Please see review comments, thanks!

@@ -60,7 +60,7 @@ pipeline "deallocate_compute_virtual_machine" {

output "stdout" {
description = "The standard output stream from the Azure CLI."
value = jsondecode(step.container.deallocate_compute_virtual_machine.stdout)
value = step.container.deallocate_compute_virtual_machine.stdout
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vkumbha Why do we not jsondecode here but do in other pipelines? What does the output look like?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbruno10 The result of deallocate and delete is an empty string. Since empty string isn't a valid JSON, using jsondecode on an empty string would result in "Unable to calculate output stdout: Internal Error: output: Error in function call: Call to function "jsondecode" failed: EOF.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vkumbha Thanks that makes sense, can you please add a comment above line 61 mentioning the output is an empty string?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbruno10 sure, made an update with comments to make it clear for someone new to understand the deviation in output value.

pipelines/compute/get_compute_virtual_machine_status.hcl Outdated Show resolved Hide resolved
pipelines/compute/list_compute_virtual_machines.hcl Outdated Show resolved Hide resolved
pipelines/compute/list_compute_virtual_machines.hcl Outdated Show resolved Hide resolved
@cbruno10 cbruno10 merged commit 4e7f277 into main Nov 20, 2023
@cbruno10 cbruno10 deleted the update-for-composite-mod branch November 20, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants