-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pipelines and update output for composite mod #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vkumbha Please see review comments, thanks!
@@ -60,7 +60,7 @@ pipeline "deallocate_compute_virtual_machine" { | |||
|
|||
output "stdout" { | |||
description = "The standard output stream from the Azure CLI." | |||
value = jsondecode(step.container.deallocate_compute_virtual_machine.stdout) | |||
value = step.container.deallocate_compute_virtual_machine.stdout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vkumbha Why do we not jsondecode here but do in other pipelines? What does the output look like?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cbruno10 The result of deallocate and delete is an empty string. Since empty string isn't a valid JSON, using jsondecode on an empty string would result in "Unable to calculate output stdout: Internal Error: output: Error in function call: Call to function "jsondecode" failed: EOF.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vkumbha Thanks that makes sense, can you please add a comment above line 61 mentioning the output is an empty string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cbruno10 sure, made an update with comments to make it clear for someone new to understand the deviation in output value.
Checklist