Skip to content

Initial implementation of async/await support #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sharwell merged 8 commits into from
Mar 5, 2016
Merged

Initial implementation of async/await support #90

sharwell merged 8 commits into from
Mar 5, 2016

Conversation

@sharwell
Copy link
Member

@sharwell sharwell commented Jul 2, 2015

This pull request adds support for async/await in .NET 3.5 applications. The implementation is based on code in https://github.com/Microsoft/referencesource, which has been modified as follows:

  • Updated to build without warnings with our StyleCop Analyzers configuration
  • Minor updates to support .NET 3.5 and .NET 4.5 in a consistent manner

@sharwell sharwell added this to the 2.0.0 milestone Jul 2, 2015
@terrajobst
Copy link

terrajobst commented Jul 10, 2015

I’m checking whether we can make Microsoft.Bcl and Microsoft.Bcl.Async available as MIT licensed .NET Reference Source. No promises, but I’ll try.

@sharwell sharwell force-pushed the async-await branch 2 times, most recently from 7cadd01 to 3e004f9 Compare July 21, 2015 03:32
@sharwell
Copy link
Member Author

sharwell commented Jul 21, 2015

@terrajobst This pull request now includes a fair number of tests for the new functionality, proving that it does bring async/await support to .NET 3.5. 🎉

@sharwell
Copy link
Member Author

sharwell commented Aug 7, 2015

@terrajobst Any update on this? 😄

@ufcpp ufcpp mentioned this pull request Oct 24, 2015
Closed
@sharwell sharwell modified the milestones: 2.1.0, 2.0.0 Oct 26, 2015
@sharwell
Copy link
Member Author

sharwell commented Oct 26, 2015

I had to move this back to 2.1.0 since it's not yet approved and I need to release a stable version 2.0.0. 😦

@terrajobst
Copy link

terrajobst commented Mar 1, 2016

@sharwell Sorry for the long delay. I think I got some traction on this now. Will keep you posted.

@sharwell
Copy link
Member Author

sharwell commented Mar 1, 2016

😄

@terrajobst
Copy link

terrajobst commented Mar 2, 2016

OK, I've clarified the licenses and submitted a PR to the Microsoft Reference Source repository: microsoft/referencesource#17 which officially identifies the source as MIT licensed.

I assume this is enough to unblock your work?

@terrajobst
Copy link

terrajobst commented Mar 2, 2016

The PR is now merged 😄

drops-mic

@sharwell
Copy link
Member Author

sharwell commented Mar 3, 2016

🎉 I'll make sure I get the notices for this project updated but I'm pretty sure this is 🎉 !!

@sharwell sharwell self-assigned this Mar 4, 2016
@codecov-io
Copy link

codecov-io commented Mar 5, 2016

Current coverage is 82.34%

Merging #90 into master will decrease coverage by -1.18% as of 8f198ef

@@            master     #90   diff @@
======================================
  Files           25      45    +20
  Stmts        12796   13294   +498
  Branches       469     547    +78
  Methods          0       0       
======================================
+ Hit          10688   10947   +259
- Partial        183     221    +38
- Missed        1925    2126   +201

Review entire Coverage Diff as of 8f198ef

Powered by Codecov. Updated on successful CI builds.

sharwell added a commit that referenced this pull request Mar 5, 2016
@sharwell
Merge pull request #90 from sharwell/async-await
c34f77c 
Initial implementation of async/await support
@sharwell sharwell merged commit c34f77c into tunnelvisionlabs:master Mar 5, 2016
@sharwell sharwell deleted the async-await branch March 5, 2016 18:11
@sharwell sharwell added fixed and removed in progress labels Mar 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sharwell sharwell

Labels

enhancement fixed

Projects

None yet

Milestone

2.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@sharwell @terrajobst @codecov-io