Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Unable to load translations in the Icons Hover Text #30

Open
ordonezgs opened this issue Jul 17, 2020 · 24 comments
Open

[Bug] Unable to load translations in the Icons Hover Text #30

ordonezgs opened this issue Jul 17, 2020 · 24 comments
Assignees
@ordonezgs
Labels
bug Something isn't working

Comments

@ordonezgs
Copy link
Collaborator

The translations informations var don't arrive to the Icons title meta of the vars(Downlockicon, Relockicon, closureicon, openicon and validationicon)

translationsInfo[translationsKeyText] gets "Undefined"
@ordonezgs ordonezgs added the bug Something isn't working label Jul 17, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.98. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@ordonezgs
Copy link
Collaborator Author

Evaluating the use of Jquery instead of the var directly to the titles.

@ordonezgs ordonezgs self-assigned this Aug 8, 2020
@ordonezgs
Copy link
Collaborator Author

WME-send-to-slack/WME-send-to-slack.user.js

Lines 151 to 167 in e9ae850

if (locklevelDiv) {
sent=0;
log('Lock icons added');
$( "#WMESTSlock" ).remove();
$('div.form-control.lock-level-selector.waze-radio-container').after('<div id="WMESTSlock">' + Downlockicon + '&nbsp;' + Relockicon + '</div>');
$( "#WMESTSvalidation" ).remove();
$('div.selection.selection-icon').append('<span id="WMESTSvalidation">' + validationicon + '</div>');
log('Validation icon added');
Loadactions();
}
if (closureslistDiv) {
sent=0;
log('Closure icons added');
$( "#WMESTSclosures" ).remove();
if(W.layerSwitcherController.checkboxState.attributes.ITEM_CLOSURES === true) {
$('.closures-list').before('<div id="WMESTSclosures">' + closureicon + '&nbsp;' + openicon + '</div>');
}

L155+

(".Downlock").attr("title", translationsInfo[X][0])
(".Lock").attr("title", translationsInfo[X][0])

L157+

(".Validation").attr("title", translationsInfo[X][0])

L166+

(".Closure").attr("title", translationsInfo[X][0])
(".Open").attr("title", translationsInfo[X][0])

Pending for Testing.

@ordonezgs ordonezgs added Awaiting Test A developer test is required In progress Currently working on it labels Aug 8, 2020
@tunisiano187
Copy link
Owner

I think it should be one line later, just after the line that append the icons, not before.
Or maybe i missunderstood your explaination

@ordonezgs
Copy link
Collaborator Author

ordonezgs commented Aug 13, 2020 •
edited
Loading

Oh!, yes. What I want to meant is that the (+) symbols means that after that line of code we will insert this code in the future.

It left to implement it and then test it. I just wrote this code for having an idea of what to test. I'm just running out of time recently so that's why it haven't been implemented yet.

@stale
Copy link

stale bot commented Aug 29, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@tunisiano187
Copy link
Owner

tunisiano187 commented Aug 29, 2020 via email

@stale stale bot removed the Pending closure label Aug 29, 2020
@stale
Copy link

stale bot commented Sep 13, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@tunisiano187
Copy link
Owner

Yes

@stale stale bot removed the Pending closure label Sep 13, 2020
@tunisiano187
Copy link
Owner

tunisiano187 commented Sep 13, 2020 via email

@stale
Copy link

stale bot commented Sep 28, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@tunisiano187
Copy link
Owner

tunisiano187 commented Sep 29, 2020 via email

@stale stale bot removed the Pending closure label Sep 29, 2020
@stale
Copy link

stale bot commented Oct 14, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale
Copy link

stale bot commented Oct 29, 2020

This issue has been automatically closed because it has not had any comments for a while, feel free to reopen it if needed

@stale stale bot closed this as completed Oct 29, 2020
@tunisiano187
Copy link
Owner

tunisiano187 commented Oct 30, 2020 via email

@ordonezgs ordonezgs removed In progress Currently working on it Pending closure labels Aug 28, 2021
@ordonezgs ordonezgs reopened this Aug 28, 2021
@stale
Copy link

stale bot commented Sep 12, 2021

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale
Copy link

stale bot commented Sep 27, 2021

This issue has been automatically closed because it has not had any comments for a while, feel free to reopen it if needed

@stale stale bot closed this as completed Sep 27, 2021
@ordonezgs ordonezgs reopened this Jun 24, 2022
@stale
Copy link

stale bot commented Jul 10, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@tunisiano187
Copy link
Owner

tunisiano187 commented Jul 10, 2022 via email

@stale stale bot removed the Pending closure label Jul 10, 2022
@stale
Copy link

stale bot commented Jul 30, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale
Copy link

stale bot commented Sep 20, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale
Copy link

stale bot commented Oct 15, 2022

This issue has been automatically closed because it has not had any comments for a while, feel free to reopen it if needed

@stale stale bot closed this as completed Oct 15, 2022
@tunisiano187
Copy link
Owner

tunisiano187 commented Oct 16, 2022 via email

@ordonezgs ordonezgs reopened this Oct 20, 2024
@stale stale bot removed the Pending closure label Oct 20, 2024
@ordonezgs ordonezgs mentioned this issue Nov 5, 2024
Merged
3 tasks
@ordonezgs
Copy link
Collaborator Author

[Fixed] It remains a bug related to when no translation translationsInfo may be undefined. This may be fixed easily later.

By the way, it left to push to production.

@ordonezgs ordonezgs added Pending closure and removed Awaiting Test A developer test is required labels Nov 6, 2024
@stale stale bot removed the Pending closure label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ordonezgs ordonezgs

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tunisiano187 @ordonezgs