-
-
Notifications
You must be signed in to change notification settings - Fork 261
Refac react frontend #790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refac react frontend #790
Conversation
63fd5d4
to
96a7f1d
Compare
c9ccbc9
to
e497e0c
Compare
For the channel overwrite endpoint, I consolidated that to the channel ID endpoint. E.g.:
Then this now also handles None and bools correctly. E.g. to "unset" or "delete" an overwrite set it to null. And True/False for the boolean values respectively. |
@bbilly1 how do i GET the channel_overwrites now? |
They are part of the regular channel data, e.g. |
@bbilly1 implemented and it works, but feels a bit quirky. But not sure why that is. |
Fixed styling selection, it was expecting dark.css to exist as a file. |
React 19 & vite 6 😁 👌 |
I've been messing around the static files, artwork and routing, trying to align local dev outside of the container and the container deployment, to be able to have both at the same time. This is my local env file I've been using: # backend/.env
TA_HOST="localhost"
TA_USERNAME=tubearchivist
TA_PASSWORD=verysecret
TA_MEDIA_DIR="static/volume/media"
TA_CACHE_DIR="static"
TA_APP_DIR="."
REDIS_HOST=localhost
ES_URL="http://localhost:9200"
ELASTIC_PASSWORD=verysecret
TZ=UTC
DJANGO_DEBUG=True Then from the backend folder you can run By pointing the Now the frontend needs to use the artwork URLs as returned from the API. You shouldn't have to do string concatenation with the ID in for example
If that doesn't work out somewhere, we'll need to make sure the API returns the correct paths. Then like this we have best of both worlds, local dev with convenient hot reload for both back and front end, and container deployment where nginx does the routing. Additionally, I also fixed the admin and restframework static files like css and js routing in nginx: e18f176 Hope that makes sense? |
25522d9
to
f0b3adb
Compare
@bbilly1 since i'm using Windows, i'm going to stay with the container for now 😅 ( got some os.uname errors when trying to install the requirements.txt ) Removed the string concatenation for image paths on channel and playlist. 👍 |
hmm, yeah, tried to install the dependencies on a windows VM. uwsgi fails, but you don't need it, as you use the dev backend server directly provided by django. But also the ldap installation fails, a very quick research showed that they don't ship windows headers, so that's unfortunate. But you don't need it if you don't activate ldap with then env var, so that might still work out... But yeah, in any case, the artwork now loads flawlessly, in dev setup as well as in the container. very convenient. I'd say, let's merge this to our react branch, and then we go from there. Very nice! :-) |
5a5d47d
into
tubearchivist:refactor-react-migration
Needs: