Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-133279 / 25.04 / Make SlideIn open type safe #11246

Merged
merged 1 commit into from
Dec 29, 2024
Merged

NAS-133279 / 25.04 / Make SlideIn open type safe #11246

merged 1 commit into from
Dec 29, 2024

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Dec 26, 2024

Changes:

  • open method now verifies that data in slideInRef and return value is of the same type. The disadvantage is that slideInRef has to be public.
  • Changes shape of swap method to match open.
  • Moves SlideIn to slide-ins module.

@undsoft undsoft requested a review from a team as a code owner December 26, 2024 21:25
@undsoft undsoft requested review from RehanY147 and removed request for a team December 26, 2024 21:25
@bugclerk bugclerk changed the title NAS-133279: Make SlideIn open type safe NAS-133279 / 25.04 / Make SlideIn open type safe Dec 26, 2024
@bugclerk
Copy link
Contributor

Jira URL: https://ixsystems.atlassian.net/browse/NAS-133279

@codecov Codecov
Copy link

codecov bot commented Dec 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.47619% with 8 lines in your changes missing coverage. Please review.

Project coverage is 82.51%. Comparing base (35832d8) to head (0f60f3a).
Report is 9 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/app/modules/slide-ins/slide-in.ts 20.00% 4 Missing ⚠️
...lide-ins/components/slide-in/slide-in.component.ts 25.00% 3 Missing ⚠️
...wo-factor-form/global-two-factor-form.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #11246   +/-   ##
=======================================
  Coverage   82.50%   82.51%           
=======================================
  Files        1655     1655           
  Lines       58943    58939    -4     
  Branches     6091     6088    -3     
=======================================
- Hits        48633    48632    -1     
+ Misses      10310    10307    -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@undsoft undsoft merged commit fc489ce into master Dec 29, 2024
9 checks passed
@undsoft undsoft deleted the NAS-133279 branch December 29, 2024 13:01
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RehanY147 RehanY147 RehanY147 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@undsoft @bugclerk @RehanY147