Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-133155 / 25.04 / Non-default account alert does not truncate #11236

Merged
merged 3 commits into from
Dec 27, 2024
Merged

NAS-133155 / 25.04 / Non-default account alert does not truncate #11236

merged 3 commits into from
Dec 27, 2024
+93 −6

Conversation

AlexKarpov98
Copy link
Contributor

Testing:
See ticket.

Result:

NAS-133155.mov

Downstream

Affects Reasoning
Documentation Added Expand/Collapse logic to the alert

@AlexKarpov98 AlexKarpov98 self-assigned this Dec 25, 2024
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner December 25, 2024 09:39
@AlexKarpov98 AlexKarpov98 requested review from undsoft and removed request for a team December 25, 2024 09:39
@bugclerk
Copy link
Contributor

Jira URL: https://ixsystems.atlassian.net/browse/NAS-133155

@bugclerk bugclerk changed the title NAS-133155: Non-default account alert does not truncate NAS-133155 / 25.04 / Non-default account alert does not truncate Dec 25, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.51%. Comparing base (2321cec) to head (b34fd69).
Report is 12 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #11236      +/-   ##
==========================================
+ Coverage   82.49%   82.51%   +0.01%     
==========================================
  Files        1651     1655       +4     
  Lines       58738    58951     +213     
  Branches     6073     6091      +18     
==========================================
+ Hits        48457    48641     +184     
- Misses      10281    10310      +29

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

undsoft
undsoft requested changes Dec 25, 2024
View reviewed changes
Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but the button looks a bit intrusive. Let's try to do something about it to either make it less noticeable or try using a link.

@AlexKarpov98
Copy link
Contributor Author

@undsoft I like how it looks now, what do you think?
Screenshot 2024-12-26 at 13 23 09

@AlexKarpov98 AlexKarpov98 requested a review from undsoft December 26, 2024 11:24
undsoft
undsoft approved these changes Dec 26, 2024
View reviewed changes
Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try with background: var(--alt-bg1);.

@AlexKarpov98 AlexKarpov98 enabled auto-merge (squash) December 27, 2024 13:00
@AlexKarpov98 AlexKarpov98 merged commit 57f6284 into master Dec 27, 2024
11 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-133155 branch December 27, 2024 13:31
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@undsoft undsoft undsoft approved these changes

Assignees

@AlexKarpov98 AlexKarpov98

Labels
no-time-tracked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexKarpov98 @bugclerk @undsoft