NAS-132938 / 25.04 / Update empty config for disk list #11227
+27
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denysbutenko
requested review from
AlexKarpov98
and removed request for
a team
bugclerk
changed the title
AlexKarpov98
approved these changes
Dec 27, 2024
This is known issue will be solved separately |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #11227 +/- ##
==========================================
- Coverage 82.51% 82.50% -0.02%
==========================================
Files 1655 1655
Lines 58951 58961 +10
Branches 6091 6093 +2
==========================================
+ Hits 48641 48643 +2
- Misses 10310 10318 +8 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Retrybutton whendataProvider.load()thrown an error.Resetbutton when empty search results in list.Testing:
Simulate network error or try to clear empty search results.