NAS-133230 / 25.04 / Fix some strict null issues #11217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/app/modules/slide-ins/components/modal-header/modal-header.component.spec.ts # src/app/modules/slide-ins/components/slide-in/slide-in.component.ts
bugclerk
changed the title
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #11217 +/- ##
==========================================
- Coverage 82.47% 82.46% -0.01%
==========================================
Files 1650 1650
Lines 58675 58697 +22
Branches 6059 6073 +14
==========================================
+ Hits 48394 48407 +13
- Misses 10281 10290 +9 ☔ View full report in Codecov by Sentry. |
# Conflicts: # src/app/pages/dashboard/components/dashboard/dashboard.component.spec.ts
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Fixes some issues in strict null mode.
Testing:
Code review is enough.