Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-133031 / 25.04 / Update audit page to master-detail view #11205

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

NAS-133031 / 25.04 / Update audit page to master-detail view #11205

wants to merge 8 commits into from

Conversation

denysbutenko
Copy link
Member

@denysbutenko denysbutenko commented Dec 18, 2024 •
edited
Loading

Changes:

  • Update audit page to master-detail view
  • Split audit component into list and search components.
  • Test cases are kept in root component due to issues with AuditApiDataProvider.

Testing:

Check audit page for regressions.

@bugclerk bugclerk changed the title Update audit page to master-detail view NAS-133031 / 25.04 / Update audit page to master-detail view Dec 18, 2024
@bugclerk
Copy link
Contributor

Jira URL: https://ixsystems.atlassian.net/browse/NAS-133031

@codecov Codecov
Copy link

codecov bot commented Dec 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.87500% with 13 lines in your changes missing coverage. Please review.

Project coverage is 82.48%. Comparing base (74755a4) to head (9ea4b69).
Report is 2 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../components/audit-search/audit-search.component.ts 91.66% 6 Missing ⚠️
...udit/components/audit-list/audit-list.component.ts 91.83% 4 Missing ⚠️
...-view/testing/mock-master-detail-view.component.ts 40.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #11205      +/-   ##
==========================================
+ Coverage   82.46%   82.48%   +0.02%     
==========================================
  Files        1650     1654       +4     
  Lines       58697    58708      +11     
  Branches     6073     6065       -8     
==========================================
+ Hits        48407    48428      +21     
+ Misses      10290    10280      -10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denysbutenko denysbutenko marked this pull request as ready for review December 20, 2024 14:50
@denysbutenko denysbutenko requested a review from a team as a code owner December 20, 2024 14:50
@denysbutenko denysbutenko requested review from RehanY147 and removed request for a team December 20, 2024 14:50
RehanY147
RehanY147 requested changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@RehanY147 RehanY147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing these errors when I try to interact with the Advanced Search or click on an item in the middle of searching
image

@denysbutenko
Copy link
Member Author

Seeing these errors when I try to interact with the Advanced Search or click on an item in the middle of searching image

The first one was fixed. The second is reproducible in main branch, ticket NAS-133252.

RehanY147
RehanY147 requested changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@RehanY147 RehanY147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can still see this error

image

@denysbutenko
Copy link
Member Author

I can still see this error

image

@RehanY147 there is no window.getElementsByClassName() usage in audit.component.ts. Did you pull the latest changes? What steps to get this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RehanY147 RehanY147 Awaiting requested review from RehanY147

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@denysbutenko @bugclerk @RehanY147