Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/Implement configuration #2

Merged
merged 1 commit into from
Mar 16, 2021
Merged

Feature/Implement configuration #2

merged 1 commit into from
Mar 16, 2021

Conversation

bestwebua
Copy link
Member

@bestwebua bestwebua commented Feb 11, 2021 •
edited
Loading

  • Implemented Configuration attr validation helpers, tests
  • Implemented Configuration/ConfigurationAttr structure, tests
  • Implemented Configuration builder, tests

@bestwebua bestwebua self-assigned this Feb 11, 2021
deniskononenkooo
deniskononenkooo reviewed Feb 19, 2021
View reviewed changes
configuration.go Outdated Show resolved Hide resolved
@bestwebua bestwebua force-pushed the feature/implement-configuration branch from b8a9544 to 2b40882 Compare February 22, 2021 18:16
deniskononenkooo
deniskononenkooo reviewed Feb 24, 2021
View reviewed changes
configuration_attr_validation.go Outdated Show resolved Hide resolved
configuration_attr_validation.go Outdated Show resolved Hide resolved
configuration_attr_validation_test.go Outdated Show resolved Hide resolved
configuration_attr_validation_test.go Outdated Show resolved Hide resolved
@bestwebua bestwebua force-pushed the feature/implement-configuration branch from 6c37c36 to a6eb218 Compare March 12, 2021 20:14
deniskononenkooo
deniskononenkooo reviewed Mar 15, 2021
View reviewed changes
configuration_attr_validation.go Show resolved Hide resolved
configuration_attr_validation.go Outdated Show resolved Hide resolved
configuration_attr_validation.go Outdated Show resolved Hide resolved
configuration_attr_validation_test.go Outdated Show resolved Hide resolved
@bestwebua bestwebua force-pushed the feature/implement-configuration branch from 83f446d to bd189cc Compare March 16, 2021 08:08
@bestwebua
Feature/Implement configuration
e7e4076 
* Implemented Configuration attr validation helpers, tests
* Implemented Configuration/ConfigurationAttr structure, tests
* Implemented Configuration builder, tests
@bestwebua bestwebua force-pushed the feature/implement-configuration branch from bd189cc to e7e4076 Compare March 16, 2021 09:40
@bestwebua bestwebua merged commit 6ca8d4b into develop Mar 16, 2021
@bestwebua bestwebua deleted the feature/implement-configuration branch March 16, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deniskononenkooo deniskononenkooo deniskononenkooo approved these changes

Assignees

@bestwebua bestwebua

Labels
reviewed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bestwebua @deniskononenkooo