Feature/decouple env vars #105
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just realized some things which are not covered by tests. --> converted to draft |
Philipp-Binder
force-pushed
the
feature/DecoupleEnvVars
branch
from
385ecc9
to
939a237
Compare
|
I've reworked the whole draft, putting test-cases to the start of the PR. But right now I will postpone the work here until the migration to superpower in #106 is completed. |
|
I like the look of this! Please update for the superpower merge, and I'll go over more granularly. But I very much like where this is headed. |
Philipp-Binder
force-pushed
the
feature/DecoupleEnvVars
branch
from
939a237
to
f896bea
Compare
|
Updating to superpower-stuff was kinda easy, but still I need to invest some time and comment some cases. I will come back here soon. |
Shows additional testingIssues due to coupling to EnvironmentVariables (ParseInterpolatedNoEnvVarsTest, ParseInterpolatedTest)
…on when having NoClobber and NoEnvVars
…ess to EnvironmentVariables inside IValue; makes ParseInterploatedNoEnvVarsTest and ParseInterpolatedTest green again breaks many other tests at this stage, because IValue does not check EnvironmentVariables now
…able dependencies in the tests where it is possible (check values differently, to be independent from EnvironmentVariables) makes test AddSourceToBuilderAndLoadMultiWithClobber red, because EnvVarSnapshot gets a reset for each load-process (new multi-file-load problem)
…arsers to EnvironmentVariables)
…epending results with "not to be clobbered" EnvVars in Env.LoadContents makes LoadMultiTestNoEnvVars green
…nvFile by solving the EnvVarSet-Logic completely into Env.LoadContents
…ibility for "NoClobber", but if one needs raw values Parsers.ParseDotEnvFile has to be used directly
…aking it just an implementationDetail for LoadMulti
…m Env inside Parsers;
Philipp-Binder
force-pushed
the
feature/DecoupleEnvVars
branch
from
f896bea
to
dd61524
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #92
Decoupling the concerns of Parsers and Env leads to a more consistent behaviour with different LoadOptions.
Namely it solves the different behaviour of Interpolation, when setting SetEnvVars to true or false.
While the parsers main responsibility now is correct parsing and returning the values from the EnvFile, the Env-class takes the responsibility about setting EnvVars, preventing clobber and so on.
With a next step it would be additionally possible to add a LoadOptions-Parameter to be able to ignore (System-)Environment variables at all, which could be a good thing if you work on a system which is polluted with EnvVars by default, and you don't want to see any side effects from your systems EnvVars.