Optimize images in README #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work, I'll take care of force pushing if it's not too destructive. |
|
Wait I saw that you changed the urls in the README, they are like this so https://themes.gohugo.io/themes/typo/ can render them correctly. Please change them to the raw path. Also, now that I think about this, I hope webp can be rendered correctly on that website. |
|
Ah, my bad. I had a feeling that could be the case too. Sure thing, will fix that. I believe rendering shouldn't be affected but the user must be using a newer browser with webp support which looks great these days: https://caniuse.com/?search=webp |
runofthemillgeek
force-pushed
the
chore/optimize-readme-images
branch
from
55d2339 to
977001f
Compare
|
@tomfran updated it. Tested render by changing the extension to .png locally so once webp files are there, should reflect that. |
tomfran
added a commit
that referenced
this pull request
Oct 30, 2024
…ages Optimize images in README
tomfran
added a commit
that referenced
this pull request
Oct 30, 2024
…ages Optimize images in README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that images in the README of this project are way too large and hence slows down page load to this repo. I converted them into webp which has reduced the size dramatically while mostly preserving the quality needed:
This should also make it easier to do shallow clones of this repo but it might be worthwhile cleaning up the large images in older commits to make it faster to do a full clone. But that's a bigger task and would need force pushes.