Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(core): add tests for card view with edgeless mode link #8887

Draft
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

L-Sun
Copy link
Contributor

@L-Sun L-Sun commented Nov 21, 2024

Close BS-1881, BS-1907, related PR toeverything/blocksuite#8785, toeverything/blocksuite#8790

This PR adds a test for the fit-to-content feature of the viewport for the embed doc block in edgeless mode.

Copy link

graphite-app bot commented Nov 21, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

L-Sun commented Nov 21, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the test Related to test cases label Nov 21, 2024
@L-Sun L-Sun added merge blocked PR is disallowed to merge due to some reasons labels Nov 21, 2024 — with Graphite App
@L-Sun L-Sun removed the merge label Nov 21, 2024
@L-Sun L-Sun marked this pull request as ready for review November 21, 2024 09:46
@graphite-app graphite-app bot requested a review from forehalo November 21, 2024 09:46
Copy link

nx-cloud bot commented Nov 21, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 342c68a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.68%. Comparing base (b60f246) to head (342c68a).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8887      +/-   ##
==========================================
- Coverage   64.73%   64.68%   -0.05%     
==========================================
  Files         664      664              
  Lines       37343    37343              
  Branches     3610     3610              
==========================================
- Hits        24175    24157      -18     
- Misses      12801    12819      +18     
  Partials      367      367              
Flag Coverage Δ
server-test 77.07% <ø> (-0.07%) ⬇️
unittest 34.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@L-Sun L-Sun marked this pull request as draft November 22, 2024 03:48
@L-Sun L-Sun changed the title test(core): viewport of embed edgeless doc should be fit test(core): add tests for card view with edgeless mode link Nov 22, 2024
L-Sun added a commit to toeverything/blocksuite that referenced this pull request Nov 22, 2024
…#8790)

Close [BS-1907](https://linear.app/affine-design/issue/BS-1907/mode=edgeless的cardview转成embed,丢失了mode信息)

This PR fixed the reference information is missing during edgeless card view conversion. The test will be added to AFFiNE side toeverything/AFFiNE#8887
@L-Sun L-Sun force-pushed the l-sun/test/viewport-fitting-of-synced-edgeless-doc branch from 72d5b7b to 8f8bd76 Compare November 22, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked PR is disallowed to merge due to some reasons test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant