Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dm-tool: add page #7710

Merged
merged 14 commits into from
Feb 2, 2022
Merged

dm-tool: add page #7710

merged 14 commits into from
Feb 2, 2022

Conversation

godalming123
Copy link
Contributor

@godalming123 godalming123 commented Jan 25, 2022 •
edited
Loading

  • The page (if new), does not already exist in the repository.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Jan 25, 2022
@godalming123 godalming123 mentioned this pull request Jan 25, 2022
Closed
6 tasks
@navarroaxel navarroaxel changed the title Add command: dm tool dm-tool: add page Jan 25, 2022
@tldr-bot

This comment has been minimized.

Sign in to view
@tldr-bot

This comment has been minimized.

Sign in to view
@CleanMachine1
Copy link
Member

Hi could please address the CI so that we can properly start begin reviewing without the CI interfering.

@godalming123
Copy link
Contributor Author

I'm not sure what the ci is. is it the bot telling me there's errors in the repo? if so I'm not sure how to address them.

CleanMachine1
CleanMachine1 reviewed Jan 29, 2022
View reviewed changes
Copy link
Member

@CleanMachine1 CleanMachine1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should fix the majority of the CI's problems

pages/linux/dm-tool.md Outdated Show resolved Hide resolved
pages/linux/dm-tool.md Outdated Show resolved Hide resolved
pages/linux/dm-tool.md Outdated Show resolved Hide resolved
pages/linux/dm-tool.md Outdated Show resolved Hide resolved
pages/linux/dm-tool.md Outdated Show resolved Hide resolved
pages/linux/dm-tool.md Outdated Show resolved Hide resolved
EmilyGraceSeville7cf
EmilyGraceSeville7cf suggested changes Jan 29, 2022
View reviewed changes
pages/linux/dm-tool.md Outdated Show resolved Hide resolved
pages/linux/dm-tool.md Outdated Show resolved Hide resolved
@tldr-bot

This comment has been minimized.

Sign in to view
@godalming123
Copy link
Contributor Author

fixed all the CI issues

@tldr-bot

This comment has been minimized.

Sign in to view
navarroaxel
navarroaxel reviewed Jan 30, 2022
View reviewed changes
pages/linux/dm-tool.md Outdated Show resolved Hide resolved
pages/linux/dm-tool.md Outdated Show resolved Hide resolved
pages/linux/dm-tool.md Outdated Show resolved Hide resolved
pages/linux/dm-tool.md Outdated Show resolved Hide resolved
pages/linux/dm-tool.md Outdated Show resolved Hide resolved
pages/linux/dm-tool.md Outdated Show resolved Hide resolved
pages/linux/dm-tool.md Outdated Show resolved Hide resolved
godalming123 and others added 7 commits January 30, 2022 19:13
@navarroaxel
remove unnecersarry charecters
481a3f6 
Co-authored-by: Axel Navarro <[email protected]>
@navarroaxel
fix spelling
0800291 
Co-authored-by: Axel Navarro <[email protected]>
@navarroaxel
remove examples from description
cd7c9fb 
Co-authored-by: Axel Navarro <[email protected]>
@navarroaxel
improve conciseness and grammer
9adce65 
Co-authored-by: Axel Navarro <[email protected]>
@navarroaxel
make example option non-optional
af3e8f4 
Co-authored-by: Axel Navarro <[email protected]>
@navarroaxel
update example
2332b2f 
Co-authored-by: Axel Navarro <[email protected]>
@navarroaxel
Improve concisness and acuracy
6e33a2b 
Co-authored-by: Axel Navarro <[email protected]>
einverne
einverne approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@einverne einverne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot verify the command now, but the format is good to me.

@godalming123
Copy link
Contributor Author

Do you want me to make a cleanup branch?

@navarroaxel navarroaxel merged commit daf0125 into tldr-pages:main Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navarroaxel navarroaxel navarroaxel left review comments

@EmilyGraceSeville7cf EmilyGraceSeville7cf EmilyGraceSeville7cf approved these changes

@einverne einverne einverne approved these changes

@CleanMachine1 CleanMachine1 Awaiting requested review from CleanMachine1

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@godalming123 @tldr-bot @CleanMachine1 @navarroaxel @einverne @EmilyGraceSeville7cf