Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raftstore: skip handle remaining messages if peer is destroyed #17841

Merged
merged 4 commits into from
Nov 19, 2024
Merged

raftstore: skip handle remaining messages if peer is destroyed #17841

merged 4 commits into from
Nov 19, 2024

Conversation

glorv
Copy link
Contributor

@glorv glorv commented Nov 18, 2024

What is changed and how it works?

Issue Number: Close #17840

What's Changed:

Skip handling remain raft messages after peer fsm is stopped. This can avoid potential panic if the raft message need to read raft log from raft engine.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels Nov 18, 2024
@glorv
use assert
03df325 
Signed-off-by: glorv <[email protected]>
@glorv
Copy link
Contributor Author

glorv commented Nov 19, 2024

@Connor1996 @overvenus PTAL

v01dstar
v01dstar approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@v01dstar v01dstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 19, 2024
Connor1996
Connor1996 approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Connor1996, v01dstar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 19, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-19 06:08:39.739957595 +0000 UTC m=+941281.930826591: ☑️ agreed by v01dstar.
  • 2024-11-19 09:08:21.411346961 +0000 UTC m=+952063.602215957: ☑️ agreed by Connor1996.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 19, 2024

@glorv: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 1174d1f into tikv:master Nov 19, 2024
8 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Nov 19, 2024
@glorv glorv added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Nov 19, 2024
@glorv glorv deleted the skip-handle-after-stop branch November 19, 2024 10:58
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #17847.

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Nov 19, 2024
@glorv @ti-chi-bot
This is an automated cherry-pick of tikv#17841
77b1a3b 
close tikv#17840

Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 19, 2024
Merged
9 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #17848.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 19, 2024
Merged
9 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Nov 19, 2024
@glorv @ti-chi-bot
This is an automated cherry-pick of tikv#17841
ab3582f 
close tikv#17840

Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #17849.

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Nov 19, 2024
@glorv @ti-chi-bot
This is an automated cherry-pick of tikv#17841
b8312a3 
close tikv#17840

Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 19, 2024
Merged
9 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #17850.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #17851.

This was referenced Nov 19, 2024
Merged
Merged
ti-chi-bot bot added a commit that referenced this pull request Nov 20, 2024
@ti-chi-bot @glorv @ti-chi-bot
raftstore: skip handle remaining messages if peer is destroyed (#17841)…
5f2ef4e 
… (#17850)

close #17840

Skip handling remain raft messages after peer fsm is stopped. This can avoid potential panic if the raft message need to read raft log from raft engine.

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: glorv <[email protected]>

Co-authored-by: glorv <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot added a commit that referenced this pull request Nov 20, 2024
@ti-chi-bot @glorv @ti-chi-bot
raftstore: skip handle remaining messages if peer is destroyed (#17841)…
d16bb1b 
… (#17851)

close #17840

Skip handling remain raft messages after peer fsm is stopped. This can avoid potential panic if the raft message need to read raft log from raft engine.

Signed-off-by: glorv <[email protected]>

Co-authored-by: glorv <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot added a commit that referenced this pull request Nov 20, 2024
@ti-chi-bot @glorv @ti-chi-bot
raftstore: skip handle remaining messages if peer is destroyed (#17841)…
8e8dae3 
… (#17848)

close #17840

Skip handling remain raft messages after peer fsm is stopped. This can avoid potential panic if the raft message need to read raft log from raft engine.

Signed-off-by: glorv <[email protected]>

Co-authored-by: glorv <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot pushed a commit that referenced this pull request Nov 20, 2024
@ti-chi-bot @glorv
raftstore: skip handle remaining messages if peer is destroyed (#17841)…
2b9a3c4 
… (#17849)

close #17840

Skip handling remain raft messages after peer fsm is stopped. This can avoid potential panic if the raft message need to read raft log from raft engine.

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: glorv <[email protected]>

Co-authored-by: glorv <[email protected]>
RidRisR pushed a commit to RidRisR/tikv that referenced this pull request Nov 20, 2024
@glorv @ti-chi-bot @RidRisR
raftstore: skip handle remaining messages if peer is destroyed (tikv#…
4b6b3ec 
…17841)

close tikv#17840

Skip handling remain raft messages after peer fsm is stopped. This can avoid potential panic if the raft message need to read raft log from raft engine.

Signed-off-by: glorv <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot added a commit that referenced this pull request Nov 25, 2024
@ti-chi-bot @glorv @ti-chi-bot
raftstore: skip handle remaining messages if peer is destroyed (#17841)…
637cb5c 
… (#17847)

close #17840

Skip handling remain raft messages after peer fsm is stopped. This can avoid potential panic if the raft message need to read raft log from raft engine.

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: glorv <[email protected]>

Co-authored-by: glorv <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
3AceShowHand pushed a commit to 3AceShowHand/tikv that referenced this pull request Nov 26, 2024
@glorv @ti-chi-bot @3AceShowHand
raftstore: skip handle remaining messages if peer is destroyed (tikv#…
a7ccf23 
…17841)

close tikv#17840

Skip handling remain raft messages after peer fsm is stopped. This can avoid potential panic if the raft message need to read raft log from raft engine.

Signed-off-by: glorv <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: 3AceShowHand <[email protected]>
@overvenus overvenus mentioned this pull request Dec 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v01dstar v01dstar v01dstar approved these changes

@Connor1996 Connor1996 Connor1996 approved these changes

@overvenus overvenus Awaiting requested review from overvenus

Assignees
No one assigned
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Pool
Development

Successfully merging this pull request may close these issues.

tikv panic in on_raft_gc_log_tick after region is merged
4 participants
@glorv @ti-chi-bot @Connor1996 @v01dstar