Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raftstore: add metrics for snapshots that are dropped #17837

Merged
merged 2 commits into from
Nov 19, 2024
Merged

raftstore: add metrics for snapshots that are dropped #17837

merged 2 commits into from
Nov 19, 2024

Conversation

hbisheng
Copy link
Member

What is changed and how it works?

Issue Number: Close #17836

What's Changed:

This commit adds metrics to track Raft snapshots that are dropped 
during sending or receiving due to concurrency limits. These metrics 
help identify bottlenecks during scaling.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

@hbisheng
raftstore: add metrics for snapshots that are dropped
30572df 
This commit adds metrics to track Raft snapshots that are dropped
during sending or receiving due to concurrency limits. These metrics
help identify bottlenecks during scaling.

Signed-off-by: Bisheng Huang <[email protected]>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 15, 2024
v01dstar
v01dstar approved these changes Nov 16, 2024
View reviewed changes
Copy link
Contributor

@v01dstar v01dstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 16, 2024
@hbisheng hbisheng requested a review from Connor1996 November 18, 2024 04:18
Connor1996
Connor1996 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Connor1996, v01dstar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 18, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-16 05:37:48.651962433 +0000 UTC m=+680230.842831423: ☑️ agreed by v01dstar.
  • 2024-11-18 08:09:44.517847428 +0000 UTC m=+862146.708716431: ☑️ agreed by Connor1996.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 18, 2024

@hbisheng: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@glorv
Copy link
Contributor

glorv commented Nov 19, 2024

/retest

@glorv
Copy link
Contributor

glorv commented Nov 19, 2024 

--- TRY 3 STDERR:        backup-stream::integration all::update_config ---

thread 'br-1::update_config-0' panicked at components/backup-stream/tests/integration/mod.rs:505:13:

assertion `left == right` failed

  left: 6

 right: 4

@hbisheng Please fix the failed case.

@hbisheng
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit b6252e9 into tikv:master Nov 19, 2024
8 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Nov 19, 2024
RidRisR pushed a commit to RidRisR/tikv that referenced this pull request Nov 20, 2024
@hbisheng @ti-chi-bot @RidRisR
raftstore: add metrics for snapshots that are dropped (tikv#17837)
1f631ae 
close tikv#17836

This commit adds metrics to track Raft snapshots that are dropped 
during sending or receiving due to concurrency limits. These metrics 
help identify bottlenecks during scaling.

Signed-off-by: Bisheng Huang <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
3AceShowHand pushed a commit to 3AceShowHand/tikv that referenced this pull request Nov 26, 2024
@hbisheng @ti-chi-bot @3AceShowHand
raftstore: add metrics for snapshots that are dropped (tikv#17837)
2025c4f 
close tikv#17836

This commit adds metrics to track Raft snapshots that are dropped
during sending or receiving due to concurrency limits. These metrics
help identify bottlenecks during scaling.

Signed-off-by: Bisheng Huang <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: 3AceShowHand <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v01dstar v01dstar v01dstar approved these changes

@Connor1996 Connor1996 Connor1996 approved these changes

Assignees
No one assigned
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Pool
Development

Successfully merging this pull request may close these issues.

Add metrics for Raft snapshots that are dropped
4 participants
@hbisheng @glorv @Connor1996 @v01dstar