Refresh Scss sample #694
Refresh Scss sample #694
Conversation
Co-authored-by: Luke Mitchell <[email protected]>
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| .class-one { | ||
| background-color: $color-variable; | ||
| border: 0; | ||
| line-height: 1.5; | ||
| text-size: 0.5rem; |
There was a problem hiding this comment.
Unexpected unknown property "text-size" property-no-unknown
| @@ -1,10 +1,16 @@ | |||
| @import "partial-name"; | |||
|
|
|||
| $color-variable: #ffffff; | |||
There was a problem hiding this comment.
Expected "#ffffff" to be "#fff" color-hex-length
|
@LkeMitchll, I pulled the sample you helped with on thoughtbot/stylelint-config#51, let me know if there's anything else you think that's worth doing here! |
|
I'd normally wait for a PR on a project such as guides for over a week for feedback, but the intent of this has been to improve our example enough that we could make substantial improvements to stylelint-config, so I'm going to go ahead and merge this. I would encourage others — with stronger feelings on CSS style than me! — to open new issues if we'd like to change, or simplify our rules. Plus we probably need to do something about Hound too. |
No description provided.