Remove guideline about using one factories.rb file per project #685
Conversation
sarahraqueld
force-pushed
the
remove-guide-about-one-big-factory-file-per-project
branch
from
6adef16 to
464e479
Compare
sarahraqueld
requested review from
jutonz,
rdnewmanbot,
elisuh and
thoughtbot-summer
|
I feel like my opinion on this changes once it gets to a certain size. When it's easy to skim up and down, one file is really helpful. But once it gets over a certain size, it's more difficult to get a feeling of the factories when scanning it. The prior rule of keeping them alphabetically sorted helps this a lot, but is not, in my experience, followed. How do people feel that we should split the file? By model? Or something else? |
I think that this is inevitable for most projects. I guess if you know your project will remain very small, keeping all of the factories in one file could make things more readable, but I've encountered very few projects like that.
I think generally one factory per file is good. |
sarahraqueld
deleted the
remove-guide-about-one-big-factory-file-per-project
branch
From my experience working with projects using FactoryBot, this guideline is not something we follow. When asking the opinion of others at thoughtbot, they agreed they prefer to split up factories into their own individual files as this makes it easier to navigate and find them, as opposed to having to look for factories in a big file.
This guideline was first introduced 11 years ago (commit) and we have learned a lot since then.
What are your thoughts?