Add a suggesting change section to code review guidelines #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggesting changes is becoming more popular, and having guidelines can make code reviews more efficient. Co-authored-by: Stefanni Brasil <[email protected]>
jutonz
reviewed
Feb 7, 2023
Co-authored-by: Justin Toniazzo <[email protected]>
Co-authored-by: Justin Toniazzo <[email protected]>
ayellapragada
approved these changes
Feb 17, 2023
matsales28
deleted the
mus-sb/add-suggestion-changes-on-code-review-guidelines
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The suggesting changes feature is becoming more popular, and having guidelines can make code reviews more efficient.
I'd appreciate any feedback on the organization structure and wording.
Co-authored-by: Stefanni Brasil [email protected]