This repository has been archived by the owner on Jul 12, 2024. It is now read-only.
Add Email#charsets reader #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow access to charsets field on Email. This allows for use by clients in custom parsing of the data later on.
houndci-bot
reviewed
Jul 24, 2017
spec/griddler/email_spec.rb
Outdated
| @@ -1026,6 +1033,7 @@ def header_from_email(header) | |||
| vendor_specific: {}, | |||
| spam_report: email.spam_report, | |||
| spam_score: email.spam_score, | |||
| charsets: email.charsets | |||
There was a problem hiding this comment.
Put a comma after the last parameter of a multiline method call.
spec/griddler/email_spec.rb
Outdated
| html: 'utf-8', | ||
| subject: 'UTF-8', | ||
| from: 'UTF-8', | ||
| text: 'iso-8859-1' |
There was a problem hiding this comment.
Put a comma after the last item of a multiline hash.
lib/griddler/email.rb
Outdated
| @@ -66,6 +69,7 @@ def to_h | |||
| vendor_specific: vendor_specific, | |||
| spam_score: spam_score, | |||
| spam_report: spam_report, | |||
| charsets: charsets | |||
There was a problem hiding this comment.
Put a comma after the last item of a multiline hash.
heidi
force-pushed
the
expose-email-charsets
branch
from
8afc316 to
964abf7
Compare
heidi
force-pushed
the
expose-email-charsets
branch
from
964abf7 to
32bd127
Compare
|
Furthermore travis failure appears to be unrelated. |
|
zokay |
|
I'll cut a new release tonight |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow access to charsets field on Email. This allows for use by
clients in custom parsing of the data later on, in tandem with
thoughtbot/griddler-sendgrid#29 for
those using the Sendgrid adapter specifically.