Skip to content

added shopify next tailwind kit #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 26, 2023
Merged

added shopify next tailwind kit #1312

merged 6 commits into from
Jul 26, 2023

Conversation

Megio
Copy link
Contributor

@Megio Megio commented Jul 26, 2023

Type of change

  • Documentation change
  • Bug fix
  • New feature

Summary of change

Added the new shopify, next and tailwind kit

Checklist

  • These changes follow the contributing guidelines
  • This starter kit has been approved by the maintainers
  • Changes for this new starter kit are being pushed to an integration branch instead of main
  • All dependencies are version locked
  • This fix resolves #
  • I have verified the fix works and introduces no further errors

@Megio Megio requested review from hdJerry and markshenouda July 26, 2023 08:36
@Megio Megio self-assigned this Jul 26, 2023
@netlify
Copy link

netlify bot commented Jul 26, 2023

Deploy Preview for starter-dev canceled.

Name Link
🔨 Latest commit ee9e321
🔍 Latest deploy log https://app.netlify.com/sites/starter-dev/deploys/64c1160b199ca10008849503

kenslachtajr
kenslachtajr previously approved these changes Jul 26, 2023
Copy link

@kenslachtajr kenslachtajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address spelling errors

### Added

- Build out journal page
- Infinte scroll on product page

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Infinite

import AuthLayout from '../component/AuthLayout';

let emailError: string | null = null;
let isSubmited: boolean = false;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be isSubmitted - spelling is not correct

export declare const IMAGE_FRAGMENT =
'#graphql\n fragment Image on Image {\n altText\n url\n width\n height\n }\n';
/**
* Hydrgen’s Image component is a wrapper around the HTML image element.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hydrogen's

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 4 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 3 Security Hotspots
Code Smell A 29 Code Smells

No Coverage information No Coverage information
1.4% 1.4% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@Megio Megio merged commit f1e91d0 into main Jul 26, 2023
@Megio Megio deleted the tdl-feat-add-shopify-next-kit branch July 26, 2023 12:52
@thisdot-bot
Copy link

Hi @Megio. 👋

Your PR has been approved and merged. 🎉

Thank you for your continued contributions to starter.dev. ❤️

Keep up the great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants