Skip to content

chore: adding error handling for usernames and setting delay for action #1309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 19, 2023
Merged

chore: adding error handling for usernames and setting delay for action #1309

merged 6 commits into from
Jul 19, 2023

Conversation

jdwilkin4
Copy link
Contributor

Type of change

  • Documentation change
  • Bug fix
  • GH action

Summary of change

This PR accomplishes the following

Resolve Issue No.1:
The notification when a PR is merged shows up pretty quickly.
We want to delay the thank you notification by a couple of minutes.

Resolves Issue No.2:
While testing the GH action earlier, we noticed that when the curl command was run to check if a user had previously contributed, it would throw an error if the user had special characters in their username.
I added a condition to account for that so the action doesn't fail.

Checklist

@jdwilkin4 jdwilkin4 self-assigned this Jul 19, 2023
@netlify
Copy link

netlify bot commented Jul 19, 2023 •
edited
Loading

✅ Deploy Preview for starter-dev canceled.

Name Link
🔨 Latest commit 3d2f009
🔍 Latest deploy log https://app.netlify.com/sites/starter-dev/deploys/64b86add6fd12b00082503f0

lindakatcodes
lindakatcodes reviewed Jul 19, 2023
View reviewed changes
Copy link
Contributor

@lindakatcodes lindakatcodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One wording question here, based on the other two PRs. 😁

@jdwilkin4 jdwilkin4 requested a review from lindakatcodes July 19, 2023 21:36
lindakatcodes
lindakatcodes reviewed Jul 19, 2023
View reviewed changes
Copy link
Contributor

@lindakatcodes lindakatcodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last suggestion 😇

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jdwilkin4 jdwilkin4 requested a review from lindakatcodes July 19, 2023 23:02
@jdwilkin4 jdwilkin4 merged commit d77dfed into main Jul 19, 2023
@jdwilkin4 jdwilkin4 deleted the chore-1308-updating-thanks-gh-actions branch July 19, 2023 23:52
@thisdot-bot
Copy link

Hi @jdwilkin4. 👋

Your PR has been approved and merged. 🎉

Thank you for your continued contributions to starter.dev. ❤️

Keep up the great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindakatcodes lindakatcodes lindakatcodes approved these changes

Assignees

@jdwilkin4 jdwilkin4

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delay notification and account for users with special character in thank you GH action
3 participants
@jdwilkin4 @thisdot-bot @lindakatcodes