feat: Add security headers in response #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcoraven
commented
Nov 24, 2024
| @@ -37,12 +37,10 @@ const QUEUES: Queue[] = [ | |||
| export const withAdminRoutes = async (fastify: FastifyInstance) => { | |||
| // Configure basic auth. | |||
| await fastify.register(fastifyBasicAuth, { | |||
| validate: (username, password, req, reply, done) => { | |||
There was a problem hiding this comment.
Updating all fastify "callback style" or "async/await" style. This will be strictly enforced in a future fastify version.
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@fastify/[email protected], npm/[email protected], npm/[email protected] |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
d4mr
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on refactoring the middleware functions in the server codebase, changing
export consttoexport function, updating CORS handling, and modifying address examples in schemas and tests. It also removes unused CORS test files and improves error handling.Detailed summary
src/tests/cors.test.ts,src/server/middleware/cors/cors.ts,src/server/middleware/cors/vary.ts,src/server/middleware/cors/index.ts.AddressSchemaandTransactionHashSchemato change examples.export functioninstead ofexport const.withCorsfunction.withEnforceEngineMode.0x000000000000000000000000000000000000dead.openApifiles.withSecurityHeadersmiddleware.