chore: track walletType usage #774
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcoraven
commented
Nov 18, 2024
| @@ -130,6 +131,8 @@ export type SmartBackendWalletType = (typeof SmartBackendWalletTypes)[number]; | |||
| export type BackendWalletType = (typeof BackendWalletTypes)[number]; | |||
| export type ParsedWalletDetails = z.infer<typeof walletDetailsSchema>; | |||
|
|
|||
| export const walletDetailsCache = new LRUMap<string, ParsedWalletDetails>(2048); | |||
There was a problem hiding this comment.
Add caching here because this is called on every write request.
Only caches if wallet details are found. Does not cache DB misses.
| // Get wallet details. For EOA and SBW (v5 endpoints), `from` should return a valid backend wallet. | ||
| // For SBW (v4 endpoints), `accountAddress` should return a valid backend wallet. | ||
| // Else the provided details are incorrect (user error). | ||
| let walletDetails: ParsedWalletDetails | undefined; |
There was a problem hiding this comment.
This is the big change @d4mr. To track walletType we need to query walletDetails for all transactions (not just SBW).
|
This PR is stale because it has been open for 7 days with no activity. Remove stale label or comment or this PR will be closed in 3 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR primarily focuses on renaming the parameter
addresstowalletAddressin various functions and files related to wallet details, enhancing clarity and consistency across the codebase. Additionally, it introduces caching for wallet details to improve performance.Detailed summary
addresstowalletAddressin multiple files:src/utils/cache/getWallet.tssrc/server/routes/backend-wallet/signMessage.tssrc/utils/account.tssrc/utils/cache/clearCache.tssrc/utils/usage.tssrc/db/wallets/getWalletDetails.tssrc/utils/transaction/insertTransaction.tswalletDetailsCacheinsrc/db/wallets/getWalletDetails.tsfor caching wallet details.walletAddressparameter.walletTypetoQueuedTransactioninsrc/utils/transaction/types.ts.insertTransactionlogic to handle wallet details more effectively.