Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to work with Payfast's latest API #1

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Updated to work with Payfast's latest API #1

wants to merge 22 commits into from

Conversation

brycelarge
Copy link

Added, missing fields, added support for notify_url.

@Xethron
Copy link

Xethron commented Jun 3, 2014

Thanks, this worked for me.

{
return $this->getParameter('testMode');
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These methods already exist on the AbstractRequest class.

@amacneil
Copy link
Member

amacneil commented Jun 4, 2014

I see the advantage of mapping field names exactly to payfast's documentation if you want to write a separate library, but the whole point of Omnipay is that it abstracts the differences between various gateway APIs (so you can use in shopping cart etc where you need a consistent interface).

@brycelarge
Copy link
Author

I understand, also when I was trying to use the omnipay/payfast I had a tough time without some detailed documentation and some working examples. I would say that each extension of omnipay should each have some working examples on the readme. I will look at conforming the changes to omnipay standards, any suggestions on the new fields the payfast api supports.

@amacneil
Copy link
Member

amacneil commented Jun 4, 2014

Sure thing, feel free to add some gateway-specific examples to the readme. I think that would be very useful.

Some bugs were encountered so I added a direct copy of payfasts php sample code they used to generate the signature.
@greydnls
Copy link
Contributor

With this branch being stale and the build failing, I'm going to close it for now. Feel free to reopen in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants