Avoid webpack to insert setImmediate#48
Merged
theKashey merged 1 commit intotheKashey:masterfrom Oct 26, 2018
ai:webpack-fix
Merged
Avoid webpack to insert setImmediate#48theKashey merged 1 commit intotheKashey:masterfrom ai:webpack-fix
theKashey merged 1 commit intotheKashey:masterfrom
ai:webpack-fix
Conversation
Merged
Owner
|
Year, I've tried it. Should be safe, as long this function will be called only on componentDidMount - ie will be ok if |
Owner
|
4.41kb confirmed. |
nickspaargaren
pushed a commit
to nickspaargaren/react-focus-lock
that referenced
this pull request
Dec 11, 2024
Avoid webpack to insert setImmediate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another optimization by Size Limit profiling data.
Webpack inserts
setImmediatepolyfill (most of your users will use webpack). AndsetImmediatebringsprocesspolyfill. But there is no need insetImmediatepolyfill here.This trick will hide
setImmediatefrom Webpack and save 1 KB gzipped JS for your users.