Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tf 0.7 workaround #349

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tgallice
Copy link
Contributor

As tf 0.7 is a very old release, I think these workarounds should be removed.

@aymericdamien
Copy link
Member

Thanks for the update but removing collections are still necessary to avoid warning messages when saving, because a dict cannot be serialized. In fact, before 0.7 it is working, but with 0.7 introduction of proobuf, it has error.

@tgallice
Copy link
Contributor Author

hum, you have totally right ! My bad... But there is no way to avoid this, keep dict values in a different way ? This workaround add a slowness in the save process, no ?

@aymericdamien
Copy link
Member

aymericdamien commented Sep 22, 2016

Yes, it is pretty hacky, I would love to find a better workaround! The slowing down should be limited (There are not that much data into these collection), and only occur when saving a model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants