Man page description of configs and parameters #2220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shreeshrii
requested changes
Feb 4, 2019
|
Updated |
|
It would be easier to have separate pull requests instead of one with several unrelated commits. The 2nd commit is fine for me, but the others are more controversial or need more care. I wonder for example whether renaming the current file |
Try to make the relationship between configs, -c and --print-parameters clearer by always using parameter and not variable. Include the filenames created by each config.
|
Rebased on master, including restoring reference to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three commits here, first two should be straightforward:
At first read of tesseract(1) I didn't find it easy to follow what a config was and the third commit is my attempt to improve that. That's more subjective so please do look at it critically.