-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevents read_lines_by_block from skipping pixels #108
base: develop
Are you sure you want to change the base?
Conversation
Every time pixels.each_slice(x_block_size).with_index do |row, block_row_number|
yield row
break if block_row_number == y_block_size - 1
end If it is the last block, the |
Would you mind adding a test that verifies the fix? |
Sure! Should be ready in a couple days |
@turboladen here it is. It kinda had the same mistake, when writing the last block it would ignore the remaining block pixels and cause the final raster to have missing pixels. |
Note: Both |
…o::NArray instead
Added the suggested changes. New code now uses Numo::NArray instead of NArray All specs are passing locally 😄 |
Fixes issue #4