New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nested markup and add tests #25

Open

subthedubdub wants to merge 1 commit into tecosaur:main from subthedubdub:unit-tests

Contributor

subthedubdub commented Oct 31, 2024

The main purpose of this PR is to add some unit tests. Not a lot (~8% coverage). Along the way, I discovered a couple of bugs.

Firstly, nested inline markup did not parse as expected. Evaluating parsetree(org"*/text/*") returned the following:

Org Parse Tree
    Section
        Paragraph
            TextBold
                TextPlain "/text/"

It now returns the following:

Org Parse Tree
    Section
        Paragraph
            TextBold
                TextItalic
                    TextPlain "text"

Secondly, the TextMarkup(::Symbol,::String) constructor was functionally broken. Granted, this constructor isn't documented.


          Add tests and fix nested markup

0c25df8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet