Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Dockerfile and Docker Push Workflow #366

Merged
merged 3 commits into from
Jan 20, 2023
Merged

Add Dockerfile and Docker Push Workflow #366

merged 3 commits into from
Jan 20, 2023

Conversation

tconbeer
Copy link
Owner

  • Add docker container option
  • fix: update Dockerfile for jinjafmt and workdir
  • fix: update changelog

@tconbeer tconbeer mentioned this pull request Jan 20, 2023
Closed
@ysmilda
Copy link
Contributor

ysmilda commented Jan 20, 2023

That makes it even easier, nice!

@tconbeer tconbeer merged commit c89a23a into main Jan 20, 2023
ysmilda
ysmilda reviewed Jan 20, 2023
View reviewed changes
.github/workflows/publish.yml
- name: Login to GitHub Container Registry
uses: docker/login-action@v2
with:
registry: ${{ env.REGISTRY }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems I've made a mistake and this should have been

registry: ghcr.io

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, fixed in #368 . And I manually pushed to ghcr for latest and v0.15.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysmilda ysmilda ysmilda left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tconbeer @ysmilda